Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArgumentException in when send GET requests in Unity 2021.1 #539

Closed
wants to merge 1 commit into from

Conversation

Velorth
Copy link

@Velorth Velorth commented Mar 29, 2021

WWW class doesn't check whether postData is null when it creates UploadHandler. This is bug in Unity 2021.1.0f1.
Anyway WWW is an obsolete class and may be removed in future versions of Unity.

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • sign contributor license agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Fixes #537

Test Plan

Test Plan:

  1. Create and setup project in Unity 2021.1.0f1
  2. Initialize FB SDK and use FB.API to create GET request (i.e. me/picture)
  3. Ensure that callback is invoked without exceptions in device log or editor console

WWW class doesn't check whether postData is null when it creates UploadHandler. This is bug in Unity 2021.1.0f1.
Anyway WWW is an obsolete class and may be removed in future versions of Unity.
@Thaina
Copy link

Thaina commented Apr 2, 2021

Hope this fixed soon

@edgargaza
Copy link

edgargaza commented Apr 12, 2021

Please, try to fix this as soon as possible. Thank you.

Copy link

@farahjr farahjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this we are unable to use the SDK.

@farahjr
Copy link

farahjr commented May 5, 2021

I'm not sure if it is releated, but after patching this version i no longer have this problem but Graph has a problem and the facebook examples will no longer work. Is there another repository for them?
image

@Velorth
Copy link
Author

Velorth commented May 5, 2021

I suppose this is because Graph API version is set to v3.0. This version is not suppoorted and should be replaced with actual version of the API.

@farahjr
Copy link

farahjr commented May 6, 2021

I suppose this is because Graph API version is set to v3.0. This version is not suppoorted and should be replaced with actual version of the API.

I have read that too.....BUT this is what it is in Unity Facebook SDK.
Anyway i figured out my problem was related to missconfiguration of Facebook Developer. I created another app there and added Facebook Login product and every thing worked. At least on my machine of course...when trying to deploy and run on my phone i got another error: 2021/05/06 10:23:52.243 16976 21572 Error GraphResponse {HttpStatus: 400, errorCode: 200, subErrorCode: -1, errorType: OAuthException, errorMessage: An access token is required to request this resource.}

And again...probably bad configuration, trying to figure it out.

Thaina added a commit to grownith/facebook-sdk-unity that referenced this pull request Jun 15, 2021
@iquintero iquintero deleted the branch facebook:dev July 28, 2021 17:33
@iquintero iquintero closed this Jul 28, 2021
@iquintero
Copy link
Contributor

Hi @Velorth can you please fork this out of master? I just deleted the dev branch since it is ~150 commits behind.

@Velorth
Copy link
Author

Velorth commented Jul 29, 2021

Hi, @iquintero, I'll do it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants